Skip to content

Commit

Permalink
Replace Folly with MapBuffer for passing js error data
Browse files Browse the repository at this point in the history
Summary:
As title, replace json serialization/deserialization and folly with MapBuffer for js error handling in Android.

Changelog:
[Android][Changed] Replace Folly with MapBuffer for passing js error data

(Note: this ignores all push blocking failures!)

Reviewed By: RSNara

Differential Revision: D38460202

fbshipit-source-id: e13a47722964baa9e0a16bb138456a19350f809e
  • Loading branch information
luluwu2032 authored and facebook-github-bot committed Aug 18, 2022
1 parent 776046b commit e874e5f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions ReactCommon/react/renderer/mapbuffer/BUCK
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
load(
"//tools/build_defs/oss:rn_defs.bzl",
"ANDROID",
"APPLE",
"CXX",
"fb_xplat_cxx_test",
"get_apple_compiler_flags",
"get_apple_inspector_flags",
Expand Down Expand Up @@ -38,7 +40,7 @@ rn_xplat_cxx_library(
"supermodule:xplat/default/public.react_native.infra",
],
macosx_tests_override = [],
platforms = ANDROID,
platforms = (ANDROID, APPLE, CXX),
preprocessor_flags = [
"-DLOG_TAG=\"ReactNative\"",
"-DWITH_FBSYSTRACE=1",
Expand All @@ -63,7 +65,7 @@ fb_xplat_cxx_test(
"-Wall",
],
contacts = ["oncall+react_native@xmail.facebook.com"],
platforms = ANDROID,
platforms = (ANDROID, APPLE, CXX),
deps = [
"//xplat/third-party/gmock:gtest",
react_native_xplat_target("react/debug:debug"),
Expand Down

0 comments on commit e874e5f

Please sign in to comment.