Fixing Yoga imports and includes on case-sensitive machines

[gabrielfurini]

Summary

In addition of the issue resolved by #26360 (already merged), machines with case-sensitive disks are still not able to build a project on Xcode due not found <yoga/... imports:

'yoga/Yoga.h' file not found

Changelog

[iOS] [Fixed] - Fix Yoga imports and includes

Test Plan

Build command on Xcode now runs successfully in a Mac with disk in case-sensitive mode

[gabrielfurini]

I've forgot to test the build in Release mode.
The commit 7b96af6 fixes it too.

[PeteTheHeat]

Thanks for the fix :)

[facebook-github-bot]

@PeteTheHeat is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[PeteTheHeat]

Hey @gabrielfurini this PR isn't landing internally because we use an internal version of Yoga which is defined in lowercase.

I'm quite surprised this broke actually. Looking at the cocoapods docs the module_name modifier set to 'yoga' here should've been enough to nullify the podspec rename.

Can you try adding spec.header_dir = 'yoga' to the podspec and seeing if that fixes your issue?

[gabrielfurini]

Hey @PeteTheHeat, I see...
Actually adding spec.header_dir = 'yoga' to the podspec fixes the problem and makes the project build again w/o renaming imports or includes. 🙌

What should we do now? Should I close this PR and open another one or you guys are gonna take care of it anyways?

Btw, would be a pleasure contributing to the repo :)

[PeteTheHeat]

Oh sweet, glad that fixes the issue :D

If you undo the header changes and amend that one line to this PR, I can re-import and land it for you 👍

[grabbou]

I will cherry-pick this directly to 0.61-stable as soon as it lands

[gabrielfurini]

Amazing, guys!
The commits renaming things are reverted and Yoga.podspec file is updated.
Also edited the PR title and description.

[facebook-github-bot]

@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @gabrielfurini in ce48896.

^{When will my fix make it into a release? | Upcoming Releases}

[PeteTheHeat]

@grabbou I don't think a cherry pick to 0.61 is needed, I don't think the Flipper/yoga changes made it into 0.61 did it?

[grabbou]

@PeteTheHeat we have cherry-picked one Yoga commit at the beginning and unfortunately, it caused this issue. I'll pick it.