Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added userInterfaceStyle to Alert to override user interface style for iOS 13+ #33553

Closed

Conversation

luoxuhai
Copy link
Contributor

@luoxuhai luoxuhai commented Apr 2, 2022

Summary

Support to override Alert interface style to match your app. For example, You want to change the style on the alert.

Changelog

[iOS] [Added] - Add userInterfaceStyle to Alert to override user interface style for iOS 13+

Test Plan

userInterfaceStyle: 'light':

userInterfaceStyle: 'dark':

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Apr 2, 2022
@react-native-bot react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Apr 2, 2022
@analysis-bot
Copy link

analysis-bot commented Apr 2, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 9f1fa91
Branch: main

@analysis-bot
Copy link

analysis-bot commented Apr 2, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,766,480 -5
android hermes armeabi-v7a 7,175,406 +0
android hermes x86 8,074,159 +3
android hermes x86_64 8,053,322 -7
android jsc arm64-v8a 9,643,772 +47
android jsc armeabi-v7a 8,418,002 +38
android jsc x86 9,592,950 +44
android jsc x86_64 10,190,136 +37

Base commit: 9f1fa91
Branch: main

@ryancat
Copy link
Contributor

ryancat commented Apr 4, 2022

Thanks for working on this! I am going to import the change and hopefully get shipped soon.

@facebook-github-bot
Copy link
Contributor

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ken0nek
Copy link
Contributor

ken0nek commented Apr 5, 2022

@ryancat cc: @lunaleaps

Do you think this comment is related to this pull request change?

For this change, we'll need to add a new method call for the new parameter to ensure we don't break for apps that use OTA.

#32538 (review)

Libraries/Alert/Alert.js Outdated Show resolved Hide resolved
@luoxuhai luoxuhai force-pushed the feature-alert-user-interface-style branch from bcf26e4 to 925c53a Compare April 5, 2022 14:06
@facebook-github-bot
Copy link
Contributor

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @luoxuhai in 47bd78f.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants