feat: Add space-separated string support for fontVariant #34641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
Base commit: bfb36c2 |
Base commit: bfb36c2 |
74 tasks
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
requested changes
Sep 13, 2022
|
|
||
| // $FlowFixMe[incompatible-type] | ||
| const match: ?____FontVariantArray_Internal = fontVariant.match( | ||
| new RegExp(/([a-zA-Z'-]+)/gm), |
There was a problem hiding this comment.
Quoting @javache:
Can we avoid regular expressions here since it's just a string split by space? This also seems like it would cause the regex to be re-compiled on every process call.
There was a problem hiding this comment.
Sure, let me update this
There was a problem hiding this comment.
FIxed @cipolleschi
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @gabrieldonadel in 09d4207. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
) Summary: This updates `fontVariant` to support space-separated string values, i.e., `'small-caps common-ligatures'`, thus aligning it with the [CSS Fonts Module Level 4](https://drafts.csswg.org/css-fonts/#font-variant-prop) specification as requested on facebook#34425. This also adds unit tests to the `processFontVariant` function ensuring the style processing works as expected. ## Changelog [General] [Added] - Add space-separated string support for fontVariant Pull Request resolved: facebook#34641 Test Plan: This can be tested either through `processFontVariant-tests` or by using the following code: ```js <Text style={{ fontVariant: 'small-caps common-ligatures', }} /> ``` Reviewed By: javache Differential Revision: D39423317 Pulled By: cipolleschi fbshipit-source-id: ad971addb423ed338e178528a11fe9d456c03e6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates
fontVariantto support space-separated string values, i.e.,'small-caps common-ligatures', thus aligning it with the CSS Fonts Module Level 4 specification as requested on #34425. This also adds unit tests to theprocessFontVariantfunction ensuring the style processing works as expected.Changelog
[General] [Added] - Add space-separated string support for fontVariant
Test Plan
This can be tested either through
processFontVariant-testsor by using the following code: