Build separate tarballs for Hermes with and without debugger #34704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 16, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create a separate hermes-engine tarball that explicitly includes the Hermes debugger, and switch the original tarball to exclude the debugger for use in release builds. Changelog: [iOS][Changed] - Remove debugger from Hermes pre-builts Differential Revision: D39326467 fbshipit-source-id: acf3503e55a9c0feb221cb2160a4391c6d502acd
hramos
force-pushed
the
export-D39326467
branch
from
002c791
to
47c5d91
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 16, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create a separate hermes-engine tarball that explicitly includes the Hermes debugger, and switch the original tarball to exclude the debugger for use in release builds. Changelog: [iOS][Changed] - Remove debugger from Hermes pre-builts Differential Revision: D39326467 fbshipit-source-id: b9d6a190f73eae7e2d8451853886a753e274c297
hramos
force-pushed
the
export-D39326467
branch
from
47c5d91
to
a464438
Compare
Base commit: c5217f1 |
Base commit: c5217f1 |
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 16, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create a separate hermes-engine tarball that explicitly includes the Hermes debugger, and switch the original tarball to exclude the debugger for use in release builds. Changelog: [iOS][Changed] - Remove debugger from Hermes pre-builts Differential Revision: D39326467 fbshipit-source-id: e3269aa1b9acb7e5162f9a627d82563aa5765fac
hramos
force-pushed
the
export-D39326467
branch
from
a464438
to
2dcf3ef
Compare
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 17, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Differential Revision: D39326467 fbshipit-source-id: e892992c894a42ff7a085d1cf1ce9c61372e9703
hramos
force-pushed
the
export-D39326467
branch
from
2dcf3ef
to
f42348f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 17, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Differential Revision: D39326467 fbshipit-source-id: ce472b4889bf42ec6c370ad45c0af58a435ff08d
hramos
force-pushed
the
export-D39326467
branch
from
f42348f
to
d4eab11
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 19, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Differential Revision: D39326467 fbshipit-source-id: 00d5b2ace2fba5872dd3c4ac7ee2ca2a40c16d34
hramos
force-pushed
the
export-D39326467
branch
from
d4eab11
to
12b7fb1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 19, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Differential Revision: D39326467 fbshipit-source-id: 3729c0a6a7fe927b1ff90e7783c4746a3013aa3e
hramos
force-pushed
the
export-D39326467
branch
from
12b7fb1
to
fe9525a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 19, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Differential Revision: D39326467 fbshipit-source-id: de8f93744a4c4fe3daa70d15ccf3a6e3cb9e4523
hramos
force-pushed
the
export-D39326467
branch
from
fe9525a
to
c4bd964
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 19, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Differential Revision: D39326467 fbshipit-source-id: 4a76f5ab712b7d3cfd930d08965744b9a6069358
hramos
force-pushed
the
export-D39326467
branch
from
c4bd964
to
ae872f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Sep 20, 2022
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Differential Revision: D39326467 fbshipit-source-id: c634fcd6a69f722b92eda66ac6a3fc77d2bbeb61
hramos
force-pushed
the
export-D39326467
branch
from
ae872f5
to
5779127
Compare
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Reviewed By: cipolleschi Differential Revision: D39326467 fbshipit-source-id: 533080f4cb97d5b9d1630087a07a5744648b9a26
hramos
force-pushed
the
export-D39326467
branch
from
5779127
to
4ecd17a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39326467 |
|
This pull request was successfully merged by @hramos in ce4aa93. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…k#34704) Summary: Pull Request resolved: facebook#34704 Create separate hermes-engine tarballs for release and debug builds, and only include the debugger in debug builds. Changes the hermes-engine podspec to use a debug Hermes build by default in order to preserve the inclusion of the debugger. Upcoming changes should split the hermes-engine Pod to allow Xcode to use release and debug builds as needed. Changelog: [iOS][Changed] - Use debug Hermes builds by default Reviewed By: cipolleschi Differential Revision: D39326467 fbshipit-source-id: 94c5fe7db80194d22fced6717c5efc7accd36d48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Create a separate hermes-engine tarball that explicitly includes the Hermes debugger, and switch the original tarball to exclude the debugger for use in release builds.
Changelog:
[iOS][Changed] - Remove debugger from Hermes pre-builts
Differential Revision: D39326467