Consume Tarball from Maven #35034
Closed
Consume Tarball from Maven #35034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently, when creating an app using the command: `npx react-native init MyApp --version nightly` iOS fails to install the dependencies because it does not find a proper tarball to run Hermes. This diff solve the problem by fetching the Hermes tarball that is created by the CI while building the nightly. ## Changelog: [iOS][Fixed] - Make the nightly work with the proper Hermes tarball Reviewed By: cortinico Differential Revision: D40512418 fbshipit-source-id: d8057207ab8d26fa318023e50434d178cc702006
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40512418 |
Base commit: e4b5d3e |
Base commit: e4b5d3e |
|
PR build artifact for 6c707fa is ready. |
|
PR build artifact for 6c707fa is ready. |
|
This pull request was successfully merged by @cipolleschi in 1546666. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35034 Currently, when creating an app using the command: `npx react-native init MyApp --version nightly` iOS fails to install the dependencies because it does not find a proper tarball to run Hermes. This diff solve the problem by fetching the Hermes tarball that is created by the CI while building the nightly. ## Changelog: [iOS][Fixed] - Make the nightly work with the proper Hermes tarball Reviewed By: cortinico Differential Revision: D40512418 fbshipit-source-id: f510f84be9f19807236091687df5e13961103318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, when creating an app using the command:
npx react-native init MyApp --version nightlyiOS fails to install the dependencies because it does not find a proper tarball to run Hermes.
This diff solve the problem by fetching the Hermes tarball that is created by the CI while building the nightly.
Changelog:
[iOS][Fixed] - Make the nightly work with the proper Hermes tarball
Reviewed By: cortinico
Differential Revision: D40512418