Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide easy regristration of C++ TurboModules in rn-tester Android #35225

Closed
wants to merge 1 commit into from
Closed

Provide easy regristration of C++ TurboModules in rn-tester Android #35225

wants to merge 1 commit into from

Conversation

christophpurrer
Copy link
Contributor

Summary:
Changelog:
[Android] [Changed] - Provide easy regristration of C++ TurboModules in rn-tester Android

Differential Revision: D41069277

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 6, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41069277

@react-native-bot react-native-bot added the Platform: Android Android applications. label Nov 6, 2022
@analysis-bot
Copy link

analysis-bot commented Nov 6, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dac6806
Branch: main

@analysis-bot
Copy link

analysis-bot commented Nov 6, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,069,290 +1,177
android hermes armeabi-v7a 6,441,440 +943
android hermes x86 7,484,363 +932
android hermes x86_64 7,343,848 +1,020
android jsc arm64-v8a 8,934,239 +1,172
android jsc armeabi-v7a 7,668,376 +958
android jsc x86 8,994,382 +939
android jsc x86_64 9,473,215 +1,014

Base commit: dac6806
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 6, 2022

PR build artifact for 7d81779 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 6, 2022
@christophpurrer @facebook-github-bot
Provide easy regristration of C++ TurboModules in rn-tester Android (f…
152b53e 
…acebook#35225)

Summary:
Pull Request resolved: facebook#35225

Changelog:
[Android] [Changed] - Provide easy regristration of C++ TurboModules in rn-tester Android

Differential Revision: D41069277

fbshipit-source-id: 06793c95b8d91d2acca0666d01cef376ffe0338d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41069277

@pull-bot
Copy link

pull-bot commented Nov 6, 2022

PR build artifact for 152b53e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 7, 2022
@christophpurrer @facebook-github-bot
Provide easy regristration of C++ TurboModules in rn-tester Android (f…
052dfbc 
…acebook#35225)

Summary:
Pull Request resolved: facebook#35225

Changelog:
[Android] [Changed] - Provide easy regristration of C++ TurboModules in rn-tester Android

Differential Revision: D41069277

fbshipit-source-id: 88f28234c4cfc29fbc9a2fd2ae0127f7ead7e4ff
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41069277

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41069277

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 7, 2022
@christophpurrer @facebook-github-bot
Provide easy regristration of C++ TurboModules in rn-tester Android (f…
4cade2e 
…acebook#35225)

Summary:
Pull Request resolved: facebook#35225

Changelog:
[Android] [Changed] - Provide easy regristration of C++ TurboModules in rn-tester Android

Differential Revision: D41069277

fbshipit-source-id: bbcad083ee663887877b1bb2a250fccfbdfc34f5
@pull-bot
Copy link

pull-bot commented Nov 7, 2022

PR build artifact for 4cade2e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41069277

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 7, 2022
@christophpurrer @facebook-github-bot
Provide easy registration of C++ TurboModules in rn-tester Android (f…
89a0d2f 
…acebook#35225)

Summary:
Pull Request resolved: facebook#35225

Changelog:
[Android] [Changed] - Provide easy registration of C++ TurboModules in rn-tester Android

Differential Revision: D41069277

fbshipit-source-id: 14a4b36605bf12e889b8e9f48396a6563667ab80
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 7, 2022
@christophpurrer @facebook-github-bot
Provide easy registration of C++ TurboModules in rn-tester Android (f…
df569d1 
…acebook#35225)

Summary:
Pull Request resolved: facebook#35225

Changelog:
[Android] [Changed] - Provide easy registration of C++ TurboModules in rn-tester Android

Differential Revision: D41069277

fbshipit-source-id: 9d8957fa2c9bebcdcf9c5ea576351444cdda5f50
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41069277

@pull-bot
Copy link

pull-bot commented Nov 7, 2022

PR build artifact for df569d1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@christophpurrer @facebook-github-bot
Provide easy registration of C++ TurboModules in rn-tester Android (f…
39e75e3 
…acebook#35225)

Summary:
Pull Request resolved: facebook#35225

Changelog:
[Android] [Changed] - Provide easy registration of C++ TurboModules in rn-tester Android

Reviewed By: javache

Differential Revision: D41069277

fbshipit-source-id: bbba62f422e6da4a3180aa60e4aac6dcc8547336
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41069277

@pull-bot
Copy link

pull-bot commented Nov 8, 2022

PR build artifact for 39e75e3 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @christophpurrer in 9cb0261.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 8, 2022
kelset pushed a commit that referenced this pull request Nov 22, 2022
@christophpurrer @kelset
Provide easy registration of C++ TurboModules in rn-tester Android (#…
775d5cd 
…35225)

Summary:
Pull Request resolved: #35225

Changelog:
[Android] [Changed] - Provide easy registration of C++ TurboModules in rn-tester Android

Reviewed By: javache

Differential Revision: D41069277

fbshipit-source-id: 450de9302df2916acf324d4c316996b185b2833f
@cipolleschi cipolleschi mentioned this pull request Nov 22, 2022
Merged
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@christophpurrer @OlimpiaZurek
Provide easy registration of C++ TurboModules in rn-tester Android (f…
a6d15d0 
…acebook#35225)

Summary:
Pull Request resolved: facebook#35225

Changelog:
[Android] [Changed] - Provide easy registration of C++ TurboModules in rn-tester Android

Reviewed By: javache

Differential Revision: D41069277

fbshipit-source-id: 450de9302df2916acf324d4c316996b185b2833f
@cipolleschi cipolleschi mentioned this pull request Aug 16, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
This was referenced Jan 8, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschi cipolleschi mentioned this pull request Apr 5, 2024
Closed
@cipolleschi cipolleschi mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christophpurrer @facebook-github-bot @analysis-bot @pull-bot @react-native-bot