Fix windows build of RectangleEdges #35516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: de7a323 |
Base commit: de7a323 |
|
PR build artifact for 23c3640 is ready. |
|
This pull request was successfully merged by @TatianaKapos in 879d303. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: [PR: Avoid emitting mountitems for default values](facebook@56e9aa3) used a constexpr in a template, which windows is unable to compile since type at this point is incomplete. Once removed, windows is able to build again. Let me know if there's a better way to fix this! See [10072](microsoft/react-native-windows#10072) for windows error messages ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - Remove constexpr from RectangleEdges.h Pull Request resolved: facebook#35516 Test Plan: Windows has forked this file and had the change for ~5 month, all tests pass on Windows side Reviewed By: javache Differential Revision: D41639514 Pulled By: rshest fbshipit-source-id: fbe595f71a7ab0accb7a76edf58ffb6aeef1ae96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR: Avoid emitting mountitems for default values used a constexpr in a template, which windows is unable to compile since type at this point is incomplete. Once removed, windows is able to build again. Let me know if there's a better way to fix this!
See 10072 for windows error messages
Changelog
[General] [Fixed] - Remove constexpr from RectangleEdges.h
Test Plan
Windows has forked this file and had the change for ~5 month, all tests pass on Windows side