chore(Podfile): fixed URL to New Arch info #37535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 98789e9 |
kelset
approved these changes
May 24, 2023
cipolleschi
approved these changes
May 24, 2023
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 6714b99. |
kelset
pushed a commit
that referenced
this pull request
May 25, 2023
Summary: I was following the upgrade helper from [0.71.7 -> 0.72.0-rc.3](https://react-native-community.github.io/upgrade-helper/?from=0.71.7&to=0.72.0-rc.3) and came across a comment with a URL in the Podfile changes. That comment lead to a 404, so this updates that to the correct URL. Confirmed this was an issue on the [Roadmap to 0.72.0](reactwg/react-native-releases#54 (comment)) ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [CHANGED] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [CHANGED] - fixed URL to New Arch info Pull Request resolved: #37535 Test Plan: Only updated a comment, no code changes Reviewed By: cortinico Differential Revision: D46145428 Pulled By: cipolleschi fbshipit-source-id: 600274222725567e1cbae041a3dac9561da15aff
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: I was following the upgrade helper from [0.71.7 -> 0.72.0-rc.3](https://react-native-community.github.io/upgrade-helper/?from=0.71.7&to=0.72.0-rc.3) and came across a comment with a URL in the Podfile changes. That comment lead to a 404, so this updates that to the correct URL. Confirmed this was an issue on the [Roadmap to 0.72.0](reactwg/react-native-releases#54 (comment)) ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [CHANGED] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [CHANGED] - fixed URL to New Arch info Pull Request resolved: facebook/react-native#37535 Test Plan: Only updated a comment, no code changes Reviewed By: cortinico Differential Revision: D46145428 Pulled By: cipolleschi fbshipit-source-id: 600274222725567e1cbae041a3dac9561da15aff Original: facebook/react-native@6714b99
This was referenced Feb 28, 2024
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: I was following the upgrade helper from [0.71.7 -> 0.72.0-rc.3](https://react-native-community.github.io/upgrade-helper/?from=0.71.7&to=0.72.0-rc.3) and came across a comment with a URL in the Podfile changes. That comment lead to a 404, so this updates that to the correct URL. Confirmed this was an issue on the [Roadmap to 0.72.0](reactwg/react-native-releases#54 (comment)) ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [CHANGED] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [CHANGED] - fixed URL to New Arch info Pull Request resolved: facebook/react-native#37535 Test Plan: Only updated a comment, no code changes Reviewed By: cortinico Differential Revision: D46145428 Pulled By: cipolleschi fbshipit-source-id: 600274222725567e1cbae041a3dac9561da15aff Original-Commit: facebook/react-native@6714b99
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: I was following the upgrade helper from [0.71.7 -> 0.72.0-rc.3](https://react-native-community.github.io/upgrade-helper/?from=0.71.7&to=0.72.0-rc.3) and came across a comment with a URL in the Podfile changes. That comment lead to a 404, so this updates that to the correct URL. Confirmed this was an issue on the [Roadmap to 0.72.0](reactwg/react-native-releases#54 (comment)) ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [CHANGED] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [CHANGED] - fixed URL to New Arch info Pull Request resolved: facebook/react-native#37535 Test Plan: Only updated a comment, no code changes Reviewed By: cortinico Differential Revision: D46145428 Pulled By: cipolleschi fbshipit-source-id: 600274222725567e1cbae041a3dac9561da15aff Original-Commit: facebook/react-native@6714b99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I was following the upgrade helper from 0.71.7 -> 0.72.0-rc.3 and came across a comment with a URL in the Podfile changes. That comment lead to a 404, so this updates that to the correct URL.
Confirmed this was an issue on the Roadmap to 0.72.0
Changelog:
[IOS] [CHANGED] - fixed URL to New Arch info
Test Plan:
Only updated a comment, no code changes