Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: debugging overlays should not have explicit height #41750

Closed
wants to merge 10 commits into from
Closed

fix: debugging overlays should not have explicit height #41750

wants to merge 10 commits into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Dec 1, 2023

Summary:

Changelog:

[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it - #38024

Here is an explanation: #38024 (comment)

Differential Revision: D50644900

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 1, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

@analysis-bot
Copy link

analysis-bot commented Dec 1, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,809,117 -133
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,200,489 +4,144
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 0c7008f
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
5e0c81c 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: c32e4d356372a9b75fde2ae2e78440b23095c990
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Dec 6, 2023
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
2492fd1 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: 8f6c52a1d7d17ef2e9c69269ecdee133168583d7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Dec 7, 2023
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
a85cc9c 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: c822fbdfd31988748a1c51a1753a622b0636cafb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 2, 2024
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
eb6451a 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: 364f176cc0c2c175c5f50c58e326508a981a259d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 4, 2024
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
c244ea2 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: 056ceba48404383e6fc0e4484f0243d6b7f01cd1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 5, 2024
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
7dffe55 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: dfe606bee80d40ca7a7d945020712d43690c3386
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 8, 2024
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
130412c 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: c618d30db1eade945097882ac1d21c691ff12635
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 11, 2024
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
8a396e3 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: dee787a809d5140c93ad343380127e9cc6d2533a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 15, 2024
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
dce0dde 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: 467fb2a7cb77413324d4f968f2929f7d2d0097d7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 15, 2024
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
6dfbfa1 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: 9ec8a15370858daeec70d4511a82b0c1a6cf78bf
Ruslan Lesiutin and others added 10 commits January 15, 2024 11:51
@facebook-github-bot
refactor[ReadOnlyNode]: lazy import ReactFabric
5be1618 
Summary:
Changelog: [Internal]

Having a static import of `ReactFabric` blocks from using `ReactNativeElement` class for Paper-only applications.

Although DOM Node APIs are Fabric-only, the ability to use `instanceof ReactNativeElement` is a nice tool for gating purposes, which currently can't be used because of the static import.

Differential Revision: D52784886

fbshipit-source-id: cf2685b3dfeca162d7a4e5e1aa303b0cfc194b11
@facebook-github-bot
fix[getInternalInstanceHandleFromPublicInstance]: make it backwards c…
3b73533 
…ompatible with previous Fabric implementation

Summary:
Changelog: [Internal]

Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version.

Fabric host components store internal instance in __internalInstanceHandle field,  previously they have been storing it in the field with the same name, but with one underscore in prefix:
https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151

Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix.

Differential Revision: D52697886

fbshipit-source-id: ee5c3a60f8bf4251ba28897d58bd6ce9fc008c1a
@facebook-github-bot
fix: patch public renderer implementations to include isChildPublicIn…
6104d70 
…stance

Summary:
Changelog: [Internal]

Manually patching public React renderers artifacts to include `isChildPublicInstance` method, which was added in facebook/react#27783.

To identifly the required changes in code I've ran a diff for 2 commits:
1. The one with the changes
2. Its parent

FB implementation were synced in D51816108.

Differential Revision: D52697885

fbshipit-source-id: b8dfbc641899516c7c62bb79bd21fae1a1981a0c
@facebook-github-bot
feat[DebuggingOverlayRegistry]: basic implementation (facebook#41743)
0e25f07 
Summary:
Pull Request resolved: facebook#41743

Changelog: [Internal]

There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component.

It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods.

In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements.

Differential Revision: D51536787

Reviewed By: rshest

fbshipit-source-id: a6a64ef5f2cec6eb10881275929272ce02038c20
@facebook-github-bot
refactor: DebuggingOverlayRegistry to handle trace updates (facebook#…
8ebb7a0 
…41744)

Summary:
Pull Request resolved: facebook#41744

Changelog: [Internal]

With these changes:
- DebuggingRegitry is responsible for listening to the events from React DevTools and
- AppContainer renders DebuggingOverlay component and subscribes with its reference to the DebuggingRegistry
- [Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51603860

Reviewed By: sammy-SC

fbshipit-source-id: 7ec87efc1ba07efe98cf9788560088653bb05856
@facebook-github-bot
feat[DebuggingOverlay]: support native commands for highlighting elem…
39cd0f1 
…ents

Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51603861

fbshipit-source-id: c836f301b38831b3ecdd6170e3077ae8a09229e3
@facebook-github-bot
refactor: DebuggingOverlayRegistry to handle native highlights from R…
8b690da 
…eact DevTools (facebook#41746)

Summary:
Pull Request resolved: facebook#41746

Changelog: [Internal]

Now using previously added `highlightElements` and `clearElementsHighlights` commands.

[Improvement] Since DebuggingRegistry is a singleton, it will only subscribe to the React DevTools events once and not *number-of-rendered-AppContainers* times.

All required functionality for highlighting elements on a single AppContainer will be added in one of the next diffs of this stack, changes are incremental.

Differential Revision: D51708053

Reviewed By: sammy-SC

fbshipit-source-id: 97f85f7b236602da9bc1b7bacf6c347ce67faec8
@facebook-github-bot
refactor: use same rectangle spec for DebuggingOverlay native commands
6974049 
Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51708055

fbshipit-source-id: 8cf3e4a1cd39c45c7350a9a06b9eab70909559b5
@facebook-github-bot
refactor: improve trace updates highlighting
f068a76 
Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D51708054

fbshipit-source-id: 33a2b89f1889963057593f3c4f296e3048a3c88c
@hoxyq @facebook-github-bot
fix: debugging overlays should not have explicit height (facebook#41750)
90229f9 
Summary:
Pull Request resolved: facebook#41750

# Changelog:
[ANDROID] [FIXED] - fixed unexpected resizing of ReactRootView for dev bundles in brownfield apps

There was an android-only issue related to brownfield apps, when React Native root view is inside a modal and resizes it  - facebook#38024

Here is an explanation: facebook#38024 (comment)

Reviewed By: NickGerleman, motiz88

Differential Revision: D50644900

fbshipit-source-id: 277a19f3cf55e1113ce3522db4eae69274b28f7f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50644900

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5d68c90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoxyq @facebook-github-bot @analysis-bot