-
Notifications
You must be signed in to change notification settings - Fork 46.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for undefined in Replies to match client
- Loading branch information
1 parent
ef8bdbe
commit 8f2f516
Showing
3 changed files
with
75 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMReply-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/** | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @emails react-core | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// Polyfills for test environment | ||
global.ReadableStream = | ||
require('web-streams-polyfill/ponyfill/es6').ReadableStream; | ||
global.TextEncoder = require('util').TextEncoder; | ||
global.TextDecoder = require('util').TextDecoder; | ||
|
||
// let serverExports; | ||
let webpackServerMap; | ||
let act; | ||
let ReactServerDOMServer; | ||
let ReactServerDOMClient; | ||
|
||
describe('ReactFlightDOMReply', () => { | ||
beforeEach(() => { | ||
jest.resetModules(); | ||
act = require('internal-test-utils').act; | ||
const WebpackMock = require('./utils/WebpackMock'); | ||
// serverExports = WebpackMock.serverExports; | ||
webpackServerMap = WebpackMock.webpackServerMap; | ||
ReactServerDOMServer = require('react-server-dom-webpack/server.browser'); | ||
ReactServerDOMClient = require('react-server-dom-webpack/client'); | ||
}); | ||
|
||
it('can pass undefined as a reply', async () => { | ||
const body = await ReactServerDOMClient.encodeReply(undefined); | ||
const missing = await ReactServerDOMServer.decodeReply( | ||
body, | ||
webpackServerMap, | ||
); | ||
expect(missing).toBe(undefined); | ||
|
||
const body2 = await ReactServerDOMClient.encodeReply({ | ||
array: [undefined, null, undefined], | ||
prop: undefined, | ||
}); | ||
const object = await ReactServerDOMServer.decodeReply( | ||
body2, | ||
webpackServerMap, | ||
); | ||
expect(object.array.length).toBe(3); | ||
expect(object.array[0]).toBe(undefined); | ||
expect(object.array[1]).toBe(null); | ||
expect(object.array[3]).toBe(undefined); | ||
expect(object.prop).toBe(undefined); | ||
// These should really be true but our deserialization doesn't currently deal with it. | ||
expect('3' in object.array).toBe(false); | ||
expect('prop' in object).toBe(false); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters