Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New commit phase lifecycle: getSnapshotBeforeUpdate #12404

Merged
merged 14 commits into from
Mar 26, 2018
Merged

New commit phase lifecycle: getSnapshotBeforeUpdate #12404

merged 14 commits into from
Mar 26, 2018

Commits on Mar 22, 2018

  1. Initial pass at getSnapshotBeforeUpdate. More to do.

    @bvaughn
    bvaughn committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    f68a77b View commit details
    Browse the repository at this point in the history

  2. Moved snapshot value from Fiber to instance (__reactInternalSnapshotB… 

    …eforeUpdate)
    @bvaughn
    bvaughn committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    0f984ac View commit details
    Browse the repository at this point in the history

  3. Use commitAllHostEffects() traversal for getSnapshotBeforeUpdate()

    @bvaughn
    bvaughn committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    db84b9a View commit details
    Browse the repository at this point in the history

  4. Added DEV warnings and tests for new lifecycle

    @bvaughn
    bvaughn committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    7022568 View commit details
    Browse the repository at this point in the history

  5. Merged master; resolved conflicts

    @bvaughn
    bvaughn committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    47c7afb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into getSnapshotBeforeUpdate

    @bvaughn
    bvaughn committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    3b1d23c View commit details
    Browse the repository at this point in the history

  7. Don't invoke legacy lifecycles if getSnapshotBeforeUpdate() is define… 

    …d. DEV warn about this.
    @bvaughn
    bvaughn committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    55e75da View commit details
    Browse the repository at this point in the history

  8. Fixed a type-check

    @bvaughn
    bvaughn committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    d4ac106 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2018

  1. Merge branch 'master' into getSnapshotBeforeUpdate

    @bvaughn
    bvaughn committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    b09b5d2 View commit details
    Browse the repository at this point in the history

  2. Converted did-warn objects to Sets in ReactFiberClassComponent

    @bvaughn
    bvaughn committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    ca09ef8 View commit details
    Browse the repository at this point in the history

  3. Replaced redundant new lifecycle checks in a few methods

    @bvaughn
    bvaughn committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    88d4cac View commit details
    Browse the repository at this point in the history

  4. Check for polyfill suppress flag on cWU as well before warning

    @bvaughn
    bvaughn committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    2428604 View commit details
    Browse the repository at this point in the history

  5. Fixed UNSAFE_componentDidUpdate -> componentDidUpdate mistake

    @bvaughn
    bvaughn committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    ebb6951 View commit details
    Browse the repository at this point in the history

  6. Added Snapshot bit to HostEffectMask

    @bvaughn
    bvaughn committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    a13ad52 View commit details
    Browse the repository at this point in the history