Remove FB specific React isomorphic build #17875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved unstable_SuspenseList internally. We don't need the FB build. I plan on also removing the ReactDOM fb specific entry. We shouldn't add any more FB specific internals nor APIs. If they're experimental they should go onto the experimental builds to avoid too many permutations.
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 001d04a:
|
bvaughn
approved these changes
Jan 21, 2020
|
I agree we need to simplify the builds and their permutations, but we should be careful we don't break something along the way. I believe the FB build has some complexities that @gaearon can maybe confirm. One of these complexities is that we apply different GCC settings for the FB prod build that doesn't mangle property/variable names (to make internal debugging easier). Furthermore, we used to apply specific FB build shims/transforms to certain modules, like the event listener module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed unstable_SuspenseList internally. We don't need the FB build. I plan on also removing the ReactDOM fb specific entry. We shouldn't add any more FB specific internals nor APIs. If they're experimental they should go onto the experimental builds to avoid too many permutations.