Misc small adjustments to build scripts #20723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update instructions to match recent script changes. Also add reproducible commit SHA to post download instructions to support publishing the Firefox DevTools extension.
facebook-github-bot
added
CLA Signed
React Core Team
|
I think I ran through all of the various scripts and the README to make sure things now match up and work. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3203821:
|
bvaughn
changed the title
acdlite
approved these changes
Feb 3, 2021
acdlite
reviewed
Feb 3, 2021
| // Otherwise fall back to parsing from the package version number. | ||
| // This is important to make the build reproducible (e.g. by Mozilla reviewers). | ||
| const buildInfoJSON = join( | ||
| cwd, |
There was a problem hiding this comment.
'Once 4783999 lands you can alternatively read from build2/COMMIT_SHA
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Also update instructions to match recent script changes. Also add reproducible commit SHA to post download instructions to support publishing the Firefox DevTools extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--buildparam from release scripts.Follow up to #20720