Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert accidentally merged PR #24080 #24081

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 12, 2022

I accidentally merged #24080, this reverts it

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 12, 2022
@sizebot
Copy link

sizebot commented Mar 12, 2022

Comparing: 581f0c4...ebd1d35

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.47% 130.94 kB 131.55 kB +0.40% 41.92 kB 42.09 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.45% 136.01 kB 136.62 kB +0.34% 43.40 kB 43.55 kB
facebook-www/ReactDOM-prod.classic.js +0.62% 435.49 kB 438.20 kB +0.43% 79.78 kB 80.12 kB
facebook-www/ReactDOM-prod.modern.js +0.37% 421.91 kB 423.48 kB +0.22% 77.76 kB 77.93 kB
facebook-www/ReactDOMForked-prod.classic.js +0.62% 435.49 kB 438.20 kB +0.43% 79.78 kB 80.12 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMTesting-prod.classic.js +0.65% 425.70 kB 428.46 kB +0.43% 79.70 kB 80.04 kB
facebook-www/ReactDOM-prod.classic.js +0.62% 435.49 kB 438.20 kB +0.43% 79.78 kB 80.12 kB
facebook-www/ReactDOMForked-prod.classic.js +0.62% 435.49 kB 438.20 kB +0.43% 79.78 kB 80.12 kB
facebook-www/ReactDOM-profiling.classic.js +0.59% 466.20 kB 468.94 kB +0.39% 84.40 kB 84.73 kB
facebook-www/ReactDOMForked-profiling.classic.js +0.59% 466.20 kB 468.94 kB +0.39% 84.40 kB 84.73 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js +0.51% 135.87 kB 136.55 kB +0.41% 43.85 kB 44.03 kB
oss-stable-semver/react-dom/umd/react-dom.production.min.js +0.47% 131.04 kB 131.65 kB +0.24% 42.64 kB 42.75 kB
oss-stable/react-dom/umd/react-dom.production.min.js +0.47% 131.04 kB 131.65 kB +0.24% 42.64 kB 42.75 kB
oss-stable-semver/react-dom/cjs/react-dom.production.min.js +0.47% 130.94 kB 131.55 kB +0.40% 41.92 kB 42.09 kB
oss-stable/react-dom/cjs/react-dom.production.min.js +0.47% 130.94 kB 131.55 kB +0.40% 41.92 kB 42.09 kB
oss-experimental/react-dom/umd/react-dom.production.min.js +0.45% 136.05 kB 136.67 kB +0.26% 44.08 kB 44.20 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.45% 136.01 kB 136.62 kB +0.34% 43.40 kB 43.55 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js +0.44% 139.80 kB 140.41 kB +0.41% 44.88 kB 45.06 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js +0.44% 139.80 kB 140.41 kB +0.41% 44.88 kB 45.06 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js +0.44% 140.38 kB 140.99 kB +0.29% 44.46 kB 44.59 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js +0.44% 140.38 kB 140.99 kB +0.29% 44.46 kB 44.59 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js +0.43% 144.79 kB 145.41 kB +0.35% 46.32 kB 46.48 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js +0.42% 145.45 kB 146.07 kB +0.29% 45.91 kB 46.04 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.39% 410.79 kB 412.40 kB +0.26% 77.38 kB 77.59 kB
facebook-www/ReactDOM-prod.modern.js +0.37% 421.91 kB 423.48 kB +0.22% 77.76 kB 77.93 kB
facebook-www/ReactDOMForked-prod.modern.js +0.37% 421.91 kB 423.48 kB +0.22% 77.76 kB 77.93 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.36% 996.67 kB 1,000.23 kB +0.36% 225.79 kB 226.60 kB
facebook-www/ReactDOM-profiling.modern.js +0.35% 452.56 kB 454.15 kB +0.21% 82.31 kB 82.48 kB
facebook-www/ReactDOMForked-profiling.modern.js +0.35% 452.56 kB 454.15 kB +0.21% 82.31 kB 82.48 kB
facebook-www/ReactDOMTesting-dev.classic.js +0.33% 1,049.31 kB 1,052.76 kB +0.26% 235.98 kB 236.59 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.32% 736.57 kB 738.96 kB +0.28% 157.12 kB 157.56 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.32% 736.57 kB 738.96 kB +0.28% 157.12 kB 157.56 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js +0.32% 1,012.35 kB 1,015.56 kB +0.22% 227.70 kB 228.21 kB
oss-stable/react-dom/cjs/react-dom.development.js +0.32% 1,012.35 kB 1,015.56 kB +0.22% 227.70 kB 228.21 kB
oss-stable-semver/react-dom/umd/react-dom.development.js +0.31% 1,062.35 kB 1,065.68 kB +0.24% 230.20 kB 230.75 kB
oss-stable/react-dom/umd/react-dom.development.js +0.31% 1,062.35 kB 1,065.68 kB +0.24% 230.20 kB 230.75 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js +0.31% 92.73 kB 93.02 kB +0.27% 28.51 kB 28.58 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js +0.31% 92.73 kB 93.02 kB +0.27% 28.51 kB 28.58 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.31% 763.50 kB 765.86 kB +0.28% 162.71 kB 163.17 kB
oss-experimental/react-dom/cjs/react-dom.development.js +0.31% 1,040.89 kB 1,044.07 kB +0.23% 233.69 kB 234.24 kB
facebook-www/ReactDOMForked-dev.classic.js +0.30% 1,138.90 kB 1,142.35 kB +0.25% 251.41 kB 252.05 kB
facebook-www/ReactDOM-dev.classic.js +0.30% 1,138.90 kB 1,142.35 kB +0.25% 251.41 kB 252.05 kB
oss-experimental/react-dom/umd/react-dom.development.js +0.30% 1,092.28 kB 1,095.58 kB +0.24% 236.18 kB 236.75 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js +0.30% 97.39 kB 97.68 kB +0.17% 29.76 kB 29.82 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js +0.29% 101.63 kB 101.92 kB +0.10% 30.69 kB 30.72 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +0.29% 101.63 kB 101.92 kB +0.10% 30.69 kB 30.72 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +0.28% 106.29 kB 106.58 kB +0.17% 32.07 kB 32.13 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.25% 1,021.64 kB 1,024.15 kB +0.20% 230.48 kB 230.94 kB
facebook-www/ReactDOMForked-dev.modern.js +0.22% 1,115.87 kB 1,118.38 kB +0.20% 247.18 kB 247.68 kB
facebook-www/ReactDOM-dev.modern.js +0.22% 1,115.87 kB 1,118.38 kB +0.20% 247.18 kB 247.68 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 88.91 kB 88.58 kB = 27.54 kB 27.39 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 88.71 kB 88.39 kB = 27.27 kB 27.15 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js = 84.66 kB 84.33 kB = 26.35 kB 26.21 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js = 84.66 kB 84.33 kB = 26.35 kB 26.21 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js = 84.46 kB 84.13 kB = 26.03 kB 25.89 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js = 84.46 kB 84.13 kB = 26.03 kB 25.89 kB

Generated by 🚫 dangerJS against ebd1d35

@acdlite acdlite merged commit 832e298 into facebook:main Mar 12, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Mar 24, 2022
Summary:
This sync includes the following changes:
- **[3f8990898](facebook/react@3f8990898 )**: Fix test-build-devtools if build was generated by build-for-devtools ([#24088](facebook/react#24088)) //<Sebastian Silbermann>//
- **[577f2de46](facebook/react@577f2de46 )**: enableCacheElement flag ([#24131](facebook/react#24131)) //<David McCabe>//
- **[2e0d86d22](facebook/react@2e0d86d22 )**: Allow updating dehydrated root at lower priority without forcing client render ([#24082](facebook/react#24082)) //<Andrew Clark>//
- **[dbe9e732a](facebook/react@dbe9e732a )**: Avoid conditions where control flow is sufficient ([#24126](facebook/react#24126)) //<Sebastian Markbåge>//
- **[b075f9742](facebook/react@b075f9742 )**: Fix dispatch config type for skipBubbling ([#24109](facebook/react#24109)) //<Luna>//
- **[ef23a9ee8](facebook/react@ef23a9ee8 )**: Flag for text hydration mismatch ([#24107](facebook/react#24107)) //<salazarm>//
- **[0412f0c1a](facebook/react@0412f0c1a )**: add offscreen state node ([#24026](facebook/react#24026)) //<Luna Ruan>//
- **[43eb28339](facebook/react@43eb28339 )**: Add skipBubbling property to dispatch config ([#23366](facebook/react#23366)) //<Luna>//
- **[832e2987e](facebook/react@832e2987e )**: Revert accdientally merged PR ([#24081](facebook/react#24081)) //<Andrew Clark>//
- **[02b65fd8c](facebook/react@02b65fd8c )**: Allow updates at lower pri without forcing client render //<Andrew Clark>//
- **[83b941a51](facebook/react@83b941a51 )**: Add isRootDehydrated function //<Andrew Clark>//
- **[c8e4789e2](facebook/react@c8e4789e2 )**: Pass children to hydration root constructor //<Andrew Clark>//
- **[581f0c42e](facebook/react@581f0c42e )**: [Flight] add support for Lazy components in Flight server ([#24068](facebook/react#24068)) //<Josh Story>//
- **[72a933d28](facebook/react@72a933d28 )**: Gate legacy hidden ([#24047](facebook/react#24047)) //<Sebastian Markbåge>//
- **[b9de50d2f](facebook/react@b9de50d2f )**: Update test to reset modules instead of using private state ([#24055](facebook/react#24055)) //<Sebastian Markbåge>//
- **[c91892ec3](facebook/react@c91892ec3 )**: [Fizz] Don't flush empty segments ([#24054](facebook/react#24054)) //<Sebastian Markbåge>//
- **[d5f1b067c](facebook/react@d5f1b067c )**: [ServerContext] Flight support for ServerContext ([#23244](facebook/react#23244)) //<salazarm>//
- **[6edd55a3f](facebook/react@6edd55a3f )**: Gate unstable_expectedLoadTime on enableCPUSuspense ([#24038](facebook/react#24038)) //<Sebastian Markbåge>//
- **[57799b912](facebook/react@57799b912 )**: Add more feature flag checks ([#24037](facebook/react#24037)) //<Sebastian Markbåge>//
- **[e09518e5b](facebook/react@e09518e5b )**: [Fizz] write chunks to a buffer with no re-use ([#24034](facebook/react#24034)) //<Josh Story>//
- **[14c2be8da](facebook/react@14c2be8da )**: Rename Node SSR Callbacks to onShellReady/onAllReady and Other Fixes ([#24030](facebook/react#24030)) //<Sebastian Markbåge>//
- **[cb1e7b1c6](facebook/react@cb1e7b1c6 )**: Move onCompleteAll to .allReady Promise ([#24025](facebook/react#24025)) //<Sebastian Markbåge>//
- **[566285761](facebook/react@566285761 )**: [Fizz] Export debug function for FB ([#24024](facebook/react#24024)) //<salazarm>//
- **[05c283c3c](facebook/react@05c283c3c )**: Fabric HostComponent as EventEmitter: support add/removeEventListener (unstable only) ([#23386](facebook/react#23386)) //<Joshua Gross>//
- **[08644348b](facebook/react@08644348b )**: Added unit Tests in the ReactART, increasing the code coverage ([#23195](facebook/react#23195)) //<BIKI DAS>//
- **[feefe437f](facebook/react@feefe437f )**: Refactor Cache Code ([#23393](facebook/react#23393)) //<Luna Ruan>//

Changelog:
[General][Changed] - React Native sync for revisions 1780659...1159ff6

jest_e2e[run_all_tests]

Reviewed By: lunaleaps

Differential Revision: D34928167

fbshipit-source-id: 8c386f2be5871981d217ab9a514892ed88eafcfb
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
This sync includes the following changes:
- **[3f8990898](facebook/react@3f8990898 )**: Fix test-build-devtools if build was generated by build-for-devtools ([facebook#24088](facebook/react#24088)) //<Sebastian Silbermann>//
- **[577f2de46](facebook/react@577f2de46 )**: enableCacheElement flag ([facebook#24131](facebook/react#24131)) //<David McCabe>//
- **[2e0d86d22](facebook/react@2e0d86d22 )**: Allow updating dehydrated root at lower priority without forcing client render ([facebook#24082](facebook/react#24082)) //<Andrew Clark>//
- **[dbe9e732a](facebook/react@dbe9e732a )**: Avoid conditions where control flow is sufficient ([facebook#24126](facebook/react#24126)) //<Sebastian Markbåge>//
- **[b075f9742](facebook/react@b075f9742 )**: Fix dispatch config type for skipBubbling ([facebook#24109](facebook/react#24109)) //<Luna>//
- **[ef23a9ee8](facebook/react@ef23a9ee8 )**: Flag for text hydration mismatch ([facebook#24107](facebook/react#24107)) //<salazarm>//
- **[0412f0c1a](facebook/react@0412f0c1a )**: add offscreen state node ([facebook#24026](facebook/react#24026)) //<Luna Ruan>//
- **[43eb28339](facebook/react@43eb28339 )**: Add skipBubbling property to dispatch config ([facebook#23366](facebook/react#23366)) //<Luna>//
- **[832e2987e](facebook/react@832e2987e )**: Revert accdientally merged PR ([facebook#24081](facebook/react#24081)) //<Andrew Clark>//
- **[02b65fd8c](facebook/react@02b65fd8c )**: Allow updates at lower pri without forcing client render //<Andrew Clark>//
- **[83b941a51](facebook/react@83b941a51 )**: Add isRootDehydrated function //<Andrew Clark>//
- **[c8e4789e2](facebook/react@c8e4789e2 )**: Pass children to hydration root constructor //<Andrew Clark>//
- **[581f0c42e](facebook/react@581f0c42e )**: [Flight] add support for Lazy components in Flight server ([facebook#24068](facebook/react#24068)) //<Josh Story>//
- **[72a933d28](facebook/react@72a933d28 )**: Gate legacy hidden ([facebook#24047](facebook/react#24047)) //<Sebastian Markbåge>//
- **[b9de50d2f](facebook/react@b9de50d2f )**: Update test to reset modules instead of using private state ([facebook#24055](facebook/react#24055)) //<Sebastian Markbåge>//
- **[c91892ec3](facebook/react@c91892ec3 )**: [Fizz] Don't flush empty segments ([facebook#24054](facebook/react#24054)) //<Sebastian Markbåge>//
- **[d5f1b067c](facebook/react@d5f1b067c )**: [ServerContext] Flight support for ServerContext ([facebook#23244](facebook/react#23244)) //<salazarm>//
- **[6edd55a3f](facebook/react@6edd55a3f )**: Gate unstable_expectedLoadTime on enableCPUSuspense ([facebook#24038](facebook/react#24038)) //<Sebastian Markbåge>//
- **[57799b912](facebook/react@57799b912 )**: Add more feature flag checks ([facebook#24037](facebook/react#24037)) //<Sebastian Markbåge>//
- **[e09518e5b](facebook/react@e09518e5b )**: [Fizz] write chunks to a buffer with no re-use ([facebook#24034](facebook/react#24034)) //<Josh Story>//
- **[14c2be8da](facebook/react@14c2be8da )**: Rename Node SSR Callbacks to onShellReady/onAllReady and Other Fixes ([facebook#24030](facebook/react#24030)) //<Sebastian Markbåge>//
- **[cb1e7b1c6](facebook/react@cb1e7b1c6 )**: Move onCompleteAll to .allReady Promise ([facebook#24025](facebook/react#24025)) //<Sebastian Markbåge>//
- **[566285761](facebook/react@566285761 )**: [Fizz] Export debug function for FB ([facebook#24024](facebook/react#24024)) //<salazarm>//
- **[05c283c3c](facebook/react@05c283c3c )**: Fabric HostComponent as EventEmitter: support add/removeEventListener (unstable only) ([facebook#23386](facebook/react#23386)) //<Joshua Gross>//
- **[08644348b](facebook/react@08644348b )**: Added unit Tests in the ReactART, increasing the code coverage ([facebook#23195](facebook/react#23195)) //<BIKI DAS>//
- **[feefe437f](facebook/react@feefe437f )**: Refactor Cache Code ([facebook#23393](facebook/react#23393)) //<Luna Ruan>//

Changelog:
[General][Changed] - React Native sync for revisions 1780659...1159ff6

jest_e2e[run_all_tests]

Reviewed By: lunaleaps

Differential Revision: D34928167

fbshipit-source-id: 8c386f2be5871981d217ab9a514892ed88eafcfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants