Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Reconciler fork (2/3) #25776

Closed
wants to merge 6 commits into from
Closed

Conversation

kassens
Copy link
Member

@kassens kassens commented Dec 2, 2022

We've heard from multiple contributors that the Reconciler forking mechanism was confusing and/or annoying to deal with. Since it's currently unused and there's no immediate plans to start using it again, this removes the forking.

Fully removing the fork is split into multiple PRs to better preserver history.

  1. Remove Reconciler fork (1/2) #25774 Remove the forking infra:
    • remove enableNewReconciler feature flag.
    • remove unstable_isNewReconciler export
    • remove eslint rules for cross fork imports
    • remove *.new.js files and update imports
  2. Remove Reconciler fork (2/3) #25776 (this PR) Merge non-suffixed files into *.old files where both exist
  3. Remove Reconciler fork (2/2) #25775 Rename *.old files

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 2, 2022
@kassens
Copy link
Member Author

kassens commented Dec 2, 2022

merged into #25774

@kassens kassens closed this Dec 2, 2022
@kassens kassens deleted the remove-fork-2 branch December 2, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants