Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Flight Encoding #26082

Merged
merged 6 commits into from
Jan 31, 2023
Merged

Refactor Flight Encoding #26082

merged 6 commits into from
Jan 31, 2023

Commits on Jan 31, 2023

  1. Change "@123" references to "$L123" 

    These are lazy references to future values. We currently claim both
$ and @ as special symbols for encoding our instructions in JSON.
We don't need two, and two are not enough anyway.
    @sebmarkbage
    sebmarkbage committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    6129a7f View commit details
    Browse the repository at this point in the history

  2. Move the row tag until after the row ID. This feels a bit easier to r… 

    …ead.
    @sebmarkbage
    sebmarkbage committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    94fe68b View commit details
    Browse the repository at this point in the history

  3. Remove the J tag and just encode JSON directly for plain models 

    JSON always starts with a punctuator or number, so there's no conflict
with the other tags.

Makes the output a little smaller and easier to read.
    @sebmarkbage
    sebmarkbage committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    87f0c3c View commit details
    Browse the repository at this point in the history

  4. Rename M module tag to I for import 

    This frees up the M up for Maps.
    @sebmarkbage
    sebmarkbage committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    de91c08 View commit details
    Browse the repository at this point in the history

  5. Serialize Symbols as an inline JSON string instead of special row 

    The serialization still emits it as a separate row since it's likely to
be reused later.
    @sebmarkbage
    sebmarkbage committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    d407b90 View commit details
    Browse the repository at this point in the history

  6. Serialize Provider as an inline JSON string instead of special row 

    We still emit it as a separate row in case it's reused but it's not needed.
    @sebmarkbage
    sebmarkbage committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    70963f8 View commit details
    Browse the repository at this point in the history