Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize Promises through Flight #26086

Merged
merged 3 commits into from
Feb 1, 2023

Commits on Feb 1, 2023

  1. Configuration menu
    Copy the full SHA
    096fe87 View commit details
    Browse the repository at this point in the history
  2. Call then() on an already instrumented promise to eager initialize it

    This ensures that we can synchronously resolve promises vendored by Flight.
    Currently, we don't attach listeners until later if the promise is already
    instrumented. Flight promises wait to resolve its content until .then()
    is called.
    
    Therefore it's never synchronously available in Fiber.
    
    This fixes that by ensuring that we always call .then() and then checking
    if we can eagerly resolve it.
    sebmarkbage committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3bea1ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d320b7a View commit details
    Browse the repository at this point in the history