[DiffTrain] Add artifacts for React Native to compiled #26204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 2cc54b5...fa22b2c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sammy-SC
force-pushed
the
difftrain-add-fbsource
branch
from
b4ea30e
to
1eb7767
Compare
poteto
reviewed
Feb 20, 2023
| ls -R ./compiled | ||
| - name: Move relevant files for React in fbsource into compiled | ||
| run: | | ||
| BASE_FOLDER='compiled/facebook-fbsource/xplat/js' |
There was a problem hiding this comment.
do you mind making this a top level, sibling dir outside of ./compiled, eg ./compiled-rn? Reason being that the commit job just pushes the entire compiled dir to www and it'd be easier to separate them
There was a problem hiding this comment.
sure, I can change it. But it is already separated during commit step where only facebook-www folder is synced to react repo. The step for commit support file_pattern.
poteto
reviewed
Feb 20, 2023
sammy-SC
commented
Feb 20, 2023
poteto
reviewed
Feb 21, 2023
sammy-SC
force-pushed
the
difftrain-add-fbsource
branch
from
fa22b2c
to
e78b26b
Compare
poteto
reviewed
Mar 17, 2023
poteto
approved these changes
Mar 17, 2023
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
DiffTrain build for commit c57b90f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.