Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename yarn start to yarn dev and yarn start:prod to yarn start #26209

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

sebmarkbage
Copy link
Collaborator

The start convention is a CRA convention but nobody else of the modern frameworks / tools use this convention for a file watcher and dev mode. Instead the common convention is dev. Instead start is for running a production build that's already been built.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 20, 2023
@react-sizebot
Copy link

react-sizebot commented Feb 20, 2023

Comparing: 62e6c46...1bfd65e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.55 kB 154.55 kB = 48.79 kB 48.79 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.54 kB 156.54 kB = 49.45 kB 49.45 kB
facebook-www/ReactDOM-prod.classic.js = 531.11 kB 531.11 kB = 94.64 kB 94.64 kB
facebook-www/ReactDOM-prod.modern.js = 515.07 kB 515.07 kB = 92.17 kB 92.17 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1bfd65e

@sebmarkbage sebmarkbage merged commit c8d4eed into facebook:main Feb 21, 2023
github-actions bot pushed a commit that referenced this pull request Feb 21, 2023
…t` (#26209)

The `start` convention is a CRA convention but nobody else of the modern
frameworks / tools use this convention for a file watcher and dev mode.
Instead the common convention is `dev`. Instead `start` is for running a
production build that's already been built.

---------

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>

DiffTrain build for commit c8d4eed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants