Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update more tests to not rely on sync queuing #26358

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Update more tests to not rely on sync queuing #26358

merged 1 commit into from
Mar 10, 2023

Commits on Mar 10, 2023

  1. Update more tests to not rely on sync queuing 

    This fixes a handful of tests that were accidentally relying on React
synchronously queuing work in the Scheduler after a setState.

Usually this is because they use a lower level SchedulerMock method
instead of either `act` or one of the `waitFor` helpers. In some cases,
the solution is to switch to those APIs. In other cases, if we're
intentionally testing some lower level behavior, we might have to be a
bit more clever.

Co-authored-by: Tianyu Yao <skyyao@fb.com>
    @acdlite @tyao1
    acdlite and tyao1 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    2aae56f View commit details
    Browse the repository at this point in the history