Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ReactDOMComponent to use flatter property operations #26433

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Refactor ReactDOMComponent to use flatter property operations #26433

merged 6 commits into from
Mar 21, 2023

Commits on Mar 20, 2023

  1. Refactor DOM Property Operations to do flatter checks

    @sebmarkbage
    sebmarkbage committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7f58c73 View commit details
    Browse the repository at this point in the history

  2. Clean up RESERVED field 

    These are now covered by switches inside each case.
    @sebmarkbage
    sebmarkbage committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    55be421 View commit details
    Browse the repository at this point in the history

  3. Inline property name string constants 

    This helps typos but it's unneccessarily clever.
    @sebmarkbage
    sebmarkbage committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0f00ead View commit details
    Browse the repository at this point in the history

  4. Inline assertValidProps 

    This removes some runtime validation for the hydration path because we
generally don't do this kind of validation against the props there. Only
if the path ends up mismatching in the children somehow.

This leads to some duplication but I plan on unifying later.
    @sebmarkbage
    sebmarkbage committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    5807323 View commit details
    Browse the repository at this point in the history

  5. Inline dangerousStyleValue

    @sebmarkbage
    sebmarkbage committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e50efd9 View commit details
    Browse the repository at this point in the history

  6. Fix function and symbol checks in boolean mustUseProperty 

    We actually only use this for BOOLEANs anyway.
    @sebmarkbage
    sebmarkbage committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    5396f17 View commit details
    Browse the repository at this point in the history