Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete processStringChunk #26896

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

sebmarkbage
Copy link
Collaborator

Follow up to #26827.

These can't include binary data and we don't really have any use cases that really require these to already be strings.

When the stream is encoded inside another protocol - such as HTML we need a different format that encode binary offsets and binary data.

These can't include binary data and we don't really have any use cases that
really require these to already be strings.

When the stream is encoded inside another protocol - such as HTML we need a
different format that encode binary offsets and binary data.
@sebmarkbage sebmarkbage requested a review from gaearon June 3, 2023 23:46
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 3, 2023
@react-sizebot
Copy link

Comparing: e6fae30...18ff594

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.23 kB 164.23 kB = 51.73 kB 51.73 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.67 kB 171.67 kB = 53.97 kB 53.97 kB
facebook-www/ReactDOM-prod.classic.js = 570.12 kB 570.12 kB = 100.58 kB 100.58 kB
facebook-www/ReactDOM-prod.modern.js = 553.90 kB 553.90 kB = 97.75 kB 97.75 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-experimental/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB
oss-stable/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.production.min.js +21.40% 0.74 kB 0.90 kB +9.78% 0.46 kB 0.51 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-client.development.js +18.33% 1.56 kB 1.84 kB +9.75% 0.73 kB 0.80 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.min.js +3.33% 1.26 kB 1.30 kB +3.71% 0.59 kB 0.62 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +3.22% 2.39 kB 2.47 kB +2.39% 0.92 kB 0.94 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 10.45 kB 10.43 kB = 4.11 kB 4.11 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 10.45 kB 10.43 kB = 4.11 kB 4.11 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-client.browser.production.min.js = 10.45 kB 10.43 kB = 4.11 kB 4.11 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 10.19 kB 10.17 kB = 4.01 kB 4.01 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 10.19 kB 10.17 kB = 4.01 kB 4.01 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.min.js = 10.19 kB 10.17 kB = 4.01 kB 4.01 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 10.17 kB 10.15 kB = 4.04 kB 4.04 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 10.17 kB 10.15 kB = 4.04 kB 4.04 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.min.js = 10.17 kB 10.15 kB = 4.04 kB 4.04 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 9.51 kB 9.49 kB = 3.72 kB 3.72 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 9.51 kB 9.49 kB = 3.72 kB 3.72 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.min.js = 9.51 kB 9.49 kB = 3.72 kB 3.72 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 49.14 kB 48.58 kB = 12.25 kB 12.17 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 49.14 kB 48.58 kB = 12.25 kB 12.17 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 49.14 kB 48.58 kB = 12.25 kB 12.17 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 47.60 kB 47.05 kB = 11.80 kB 11.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 47.60 kB 47.05 kB = 11.80 kB 11.72 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 47.60 kB 47.05 kB = 11.80 kB 11.72 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 46.70 kB 46.15 kB = 11.58 kB 11.50 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 46.70 kB 46.15 kB = 11.58 kB 11.50 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 46.70 kB 46.15 kB = 11.58 kB 11.50 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 44.16 kB 43.47 kB = 11.16 kB 11.03 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 44.16 kB 43.47 kB = 11.16 kB 11.03 kB
oss-stable/react-client/cjs/react-client-flight.development.js = 44.16 kB 43.47 kB = 11.16 kB 11.03 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 10.09 kB 9.90 kB = 4.00 kB 3.97 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 10.09 kB 9.90 kB = 4.00 kB 3.97 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.min.js = 10.09 kB 9.90 kB = 4.00 kB 3.97 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 9.71 kB 9.52 kB = 3.81 kB 3.78 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 9.71 kB 9.52 kB = 3.81 kB 3.78 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.min.js = 9.71 kB 9.52 kB = 3.81 kB 3.78 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.min.js = 9.39 kB 9.20 kB = 3.68 kB 3.65 kB
oss-experimental/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB
oss-stable/react-client/cjs/react-client-flight.production.min.js = 8.50 kB 8.22 kB = 3.36 kB 3.29 kB

Generated by 🚫 dangerJS against 18ff594

@sebmarkbage sebmarkbage merged commit ce6842d into facebook:main Jun 10, 2023
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Follow up to facebook#26827.

These can't include binary data and we don't really have any use cases
that really require these to already be strings.

When the stream is encoded inside another protocol - such as HTML we
need a different format that encode binary offsets and binary data.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Follow up to #26827.

These can't include binary data and we don't really have any use cases
that really require these to already be strings.

When the stream is encoded inside another protocol - such as HTML we
need a different format that encode binary offsets and binary data.

DiffTrain build for commit ce6842d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants