Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Instrument the Promise for Async Module instead of using a Module Cache #26985

Merged
merged 4 commits into from
Jun 28, 2023
Merged

[Flight] Instrument the Promise for Async Module instead of using a Module Cache #26985

merged 4 commits into from
Jun 28, 2023

Commits on Jun 21, 2023

  1. Add Async Module Test 

    This is a bit tricky to test because it really requires both the server
and the client to be bundled so that the server knows it would've been
an async import so it can tag it as such.
    @sebmarkbage
    sebmarkbage committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    bcfcde2 View commit details
    Browse the repository at this point in the history

  2. Add Async Module Support to the Unbundled Mode

    @sebmarkbage
    sebmarkbage committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    91216ea View commit details
    Browse the repository at this point in the history

  3. Instrument the Promise for async modules instead of using a cache 

    We typically do this for Promises in general. Usually the ones we provide.

This ensures that if Webpack replaces the module (HMR) then we'll get the
new Promise when we require it again.
    @sebmarkbage
    sebmarkbage committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8b5b3c5 View commit details
    Browse the repository at this point in the history

  4. Weird prettier fix since we use flow parser

    @sebmarkbage
    sebmarkbage committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    705df6d View commit details
    Browse the repository at this point in the history