Support wrapGenerator.isGeneratorFunction #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook will likely prove useful in more ways in the future, but for now it's primarily useful for setting the .constructor property of the generator function to the GeneratorFunction constructor in order to support wrapGenerator.isGeneratorFunction. Closes #48.
| false | ||
| ); | ||
|
|
||
| if (n.FunctionDeclaration.check(node)) { |
There was a problem hiding this comment.
Note to self: this case really deserves some comments.
benjamn
added a commit
that referenced
this pull request
Nov 2, 2013
Support wrapGenerator.isGeneratorFunction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my current best effort to resolve #48.
These changes should also support implementations of
isGeneratorFunctionthat don't have access to theGeneratorFunctionconstructor for direct comparison, such as https://github.com/visionmedia/co/blob/c247a120e3/index.js#L201-L211.cc @TooTallNate @raynor