Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with Clang 11 #7352

Closed
thekvs opened this issue Sep 5, 2020 · 1 comment
Closed

Fails to build with Clang 11 #7352

thekvs opened this issue Sep 5, 2020 · 1 comment

Comments

@thekvs
Copy link

thekvs commented Sep 5, 2020

/<skipped>/rocksdb/options/options_helper.cc:659:19: error: loop variable 'iter' creates a copy from type 'const std::__1::pair<const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, rocksdb::OptionTypeInfo>' [-Werror,-Wrange-loop-construct]
  for (const auto iter : type_info) {
                  ^
/<skipped>/rocksdb/options/options_helper.cc:659:8: note: use reference type 'const std::__1::pair<const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, rocksdb::OptionTypeInfo> &' to prevent copying
  for (const auto iter : type_info) {
       ^~~~~~~~~~~~~~~~~
                  &

RocksDB version 6.11.4
Clang version 11
Ubuntu 18.04.5 LTS

@jay-zhuang
Copy link
Contributor

It should already be fixed by #7025

Please re-open if needed.

yiwu-arbug pushed a commit to tikv/rocksdb that referenced this issue Sep 28, 2020
I needed these changes to run `make` successfully.

See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352

Signed-off-by: Greg Weber <greg@pingcap.com>
Co-authored-by: yiwu-arbug <yiwu@pingcap.com>
breezewish pushed a commit to breezewish/tikv-rocksdb that referenced this issue Dec 18, 2020
I needed these changes to run `make` successfully.

See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352

Signed-off-by: Breezewish <me@breeswish.org>
yiwu-arbug pushed a commit to tikv/rocksdb that referenced this issue Dec 18, 2020
I needed these changes to run `make` successfully.

See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352

Signed-off-by: Breezewish <me@breeswish.org>

Co-authored-by: Greg Weber <greg@gregweber.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants