Bugfix to ensure that logging can be achieved from any thread #1106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our application build atop RocksDB we would occasionally see
SIGSEGV
when background flushes were run.This was caused by the call to
env->FindClass("org/rocksdb/InfoLogLevel")
inportal.h
returningnullptr
. That would happen if the thread calling that was not known to the JVM, e.g. it was created from C++ bypthread_create
or similar, callingFindClass
from that unknown thread means the JVM cannot find the classloader and so does not locate the class. See also http://developer.android.com/training/articles/perf-jni.html#faq_FindClassThis PR fixes that by caching Global References to the objects that are needed for logging when the logger is first instantiated.
For reference, the
SIGSEGV
's that we were seeing looked like: