Remove RocksDB LITE #11147
Remove RocksDB LITE #11147
Conversation
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
LGTM! I just compared the differences with my auto-generated start in #11145
For the long term record, please add to your summary the tool command line from my PR description. Thanks!
Summary: We haven't been actively mantaining RocksDB LITE recently and the size must have been gone up significantly. We are removing the support. Test Plan: See CI
|
@siying has updated the pull request. You must reimport the pull request before landing. |
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Not that it needs to be part of this PR, but the "FactoryFunc" methods to the LoadXXXObject methods in include/rocksdb/utilities/customizable_util.h were necessary to support the LITE case. If LITE is being removed, those methods/signatures can be as well. |
|
This pull request has been merged in 4720ba4. |
Summary:
We haven't been actively mantaining RocksDB LITE recently and the size must have been gone up significantly. We are removing the support.
Most of changes were done through following comments:
unifdef -m -UROCKSDB_LITE
git grep -l ROCKSDB_LITE | egrep '[.](cc|h)'by Peter Dillinger. Others changes were manually applied to build scripts, CircleCI manifests, ROCKSDB_LITE is used in an expression and file db_stress_test_base.cc.
Test Plan: See CI