Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add multiget JNI bindings #131

Merged
merged 8 commits into from
Apr 30, 2014
Merged

[Java] Add multiget JNI bindings #131

merged 8 commits into from
Apr 30, 2014

Conversation

ankgup87
Copy link
Contributor

Summary:

  1. Add multi-get JNI bindings
  2. Unit-tests for multi-get

make rocksdbjava
make sample

Reviewers: haobo, yhchiang, sdong, dhruba, rsumbaly, zzbennett, swapnilghike

Reviewed By: yhchiang

CC: leveldb

Differential Revision: https://reviews.facebook.net/D18369

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@yhchiang
Copy link
Contributor

Hello @ankgup87, in case you haven't sign up at https://code.facebook.com/cla. Would you mind trying to sign up? I will accept the merge later on. Let me know if you encounter any problem.

@ankgup87
Copy link
Contributor Author

Strange.! I had signed it before. Can you please check if all is good now?

yhchiang added a commit that referenced this pull request Apr 30, 2014
[Java] Add multiget JNI bindings
@yhchiang yhchiang merged commit 2e11e47 into facebook:master Apr 30, 2014
@yhchiang
Copy link
Contributor

Not sure how to check this for people other than myself, but in my case when I try to sign up, it will show the following message, indicating that I have been registered. Do you see similar message as follows?

"The 'GitHub' value has been registered on this form before. If you would like to update an existing contributor account, please email cla@fb.com with your details."

Little-Wallace added a commit to Little-Wallace/rocksdb that referenced this pull request Dec 9, 2021
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Support write multiple WriteBatch into RocksDB together. These WriteBatch will be assigned sequence number in order and pushed into queue. If a thread is waiting for some state, it could steal some job from work queue.
BusyJay pushed a commit to BusyJay/rocksdb that referenced this pull request Jul 25, 2022
* add multibatch write into memtable (facebook#131)

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Support write multiple WriteBatch into RocksDB together. These WriteBatch will be assigned sequence number in order and pushed into queue. If a thread is waiting for some state, it could steal some job from work queue.

Signed-off-by: tabokie <xy.tao@outlook.com>

* Improve Multi Batch Write (facebook#154)

* perform like normal pipelined write

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: tabokie <xy.tao@outlook.com>

* pass enable_multi_thread_write to BuildDBOptions (facebook#170)

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: tabokie <xy.tao@outlook.com>

* Fix life time of `memtable_write_group` (facebook#171)

* fix life time of memtable_write_group

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: tabokie <xy.tao@outlook.com>

* Commit pipeline when write a WriteBatch for linearizability (facebook#267)

* support commit pipeline

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: tabokie <xy.tao@outlook.com>

* format

Signed-off-by: tabokie <xy.tao@outlook.com>

* remove useless code

Signed-off-by: tabokie <xy.tao@outlook.com>

Co-authored-by: Wallace <bupt2013211450@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants