Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory usage stats in C API #4340

Closed
wants to merge 1 commit into from

Conversation

vitalyisaev2
Copy link
Contributor

@vitalyisaev2 vitalyisaev2 commented Sep 4, 2018

Please consider this small PR providing access to the MemoryUsage::GetApproximateMemoryUsageByType function in plain C API. Actually I'm working on Go application and now trying to investigate the reasons of high memory consumption (#4313). Go wrappers are built on the top of Rocksdb C API. According to the #706, MemoryUsage::GetApproximateMemoryUsageByType is considered as the best option to get database internal memory usage stats, but it wasn't supported in C API yet.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants