Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MerkleTree, Segment, ColMatrix changes for GPU RPO support #185

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Apr 14, 2023

Changes:

  • Make MerkleTree fields public so the merkle nodes can be generated in a custom way (on the GPU in my case)
  • Add merge_column to ColMatrix to append columns
  • Make get_offsets public
  • Make Segment public
  • remove .data() from Segment and instead implement Deref (gives access to the data Vec instead of the slice which I need to call .capacity() on)

@facebook-github-bot
Copy link

Hi @andrewmilson!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! I left a few small comments inline - mostly related to API ergonomics.

prover/src/lib.rs Outdated Show resolved Hide resolved
prover/src/matrix/row_matrix.rs Outdated Show resolved Hide resolved
prover/src/matrix/segments.rs Outdated Show resolved Hide resolved
crypto/src/merkle/mod.rs Outdated Show resolved Hide resolved
@andrewmilson andrewmilson marked this pull request as ready for review April 16, 2023 00:42
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@andrewmilson andrewmilson changed the title Gpu rpo support MerkleTree, Segment, ColMatrix changes for GPU RPO support Apr 16, 2023
@irakliyk irakliyk merged commit 7c1a56d into facebook:main Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants