Speedup proof verification using batched inverse. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irakliyk
requested changes
Apr 25, 2023
Comment on lines
111
to
112
| // compute T'_i(x) = (T_i(x) - T_i(z)) / (x - z), multiply it by a composition | ||
| // coefficient, and add the result to T(x) |
There was a problem hiding this comment.
I wonder if these comments need to be complemented. Conceptually, this is still what's happening, but the actual code below is different. It would probably be good to leave comments somewhere explaining the approach.
Comment on lines
119
to
120
| // compute T''_i(x) = (T_i(x) - T_i(z * g)) / (x - z * g), multiply it by a | ||
| // composition coefficient, and add the result to T(x) |
There was a problem hiding this comment.
Similar comment regarding comments.
|
|
||
| // compute z^m | ||
| let num_evaluation_columns = ood_evaluations.len() as u32; | ||
| let z_m = self.z[0].exp_vartime(num_evaluation_columns.into()); | ||
|
|
||
| for (query_values, &x) in queried_evaluations.rows().zip(&self.x_coordinates) { | ||
| let mut composition = E::ZERO; | ||
| let mut composition_num = E::ZERO; | ||
| let mut composition_den = E::ONE; | ||
| for (i, &evaluation) in query_values.iter().enumerate() { | ||
| // compute H'_i(x) = (H_i(x) - H_i(z^m)) / (x - z^m) |
There was a problem hiding this comment.
Similar comment regarding comments.
irakliyk
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses batch inverse function to save some cycles during verification.
This was derived while working on zkDilithium as part of ia.cr/2023/414.