Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove From impls resulting in silent field element conversions #243

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Remove From impls resulting in silent field element conversions #243

merged 1 commit into from
Feb 5, 2024

Conversation

irakliyk
Copy link
Collaborator

This PR addresses #230 and also does the same for f62 and f128 field.

Other changes in this PR:

  • Cleaned up code as per clippy suggestions.
  • Made some functions const for f64 field.
  • Added as_int() implementation to the f64 field struct.

plafer
plafer reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I much prefer not having the from() implementation! But I wonder if we should make new() also return a Result?

Otherwise left a few nits

math/src/field/f62/tests.rs Show resolved Hide resolved
air/src/proof/context.rs Show resolved Hide resolved
air/src/proof/context.rs Show resolved Hide resolved
air/src/proof/context.rs Show resolved Hide resolved
math/src/fft/concurrent.rs Show resolved Hide resolved
math/src/fft/concurrent.rs Show resolved Hide resolved
@irakliyk irakliyk merged commit 42fc439 into main Feb 5, 2024
9 checks passed
@irakliyk irakliyk deleted the field-conversions branch February 5, 2024 06:19
@irakliyk irakliyk mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer left review comments

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irakliyk @plafer @facebook-github-bot