Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TraceOodFrame #266

Merged
merged 14 commits into from
Mar 27, 2024
Merged

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Mar 26, 2024

Applies #247 (comment)

@irakliyk irakliyk self-requested a review March 27, 2024 06:31
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left just one small nit comment inline.

air/src/proof/ood_frame.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@irakliyk irakliyk merged commit ee09344 into facebook:next Mar 27, 2024
9 checks passed
irakliyk pushed a commit that referenced this pull request May 9, 2024
irakliyk pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants