-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GKR-LogUp API #287
Fix GKR-LogUp API #287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few small comments inline. After these are addressed, we can merge.
I do have some bigger comments which go beyond this PR - I'll write them up in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Thank you!
Closes #286
I opted to expand the scope of the current
Air::evaluate_aux_transition()
andAir::get_aux_assertions()
instead of creating new methods (as suggested in the issue), since it ended up being much cleaner.