Selection breaks when Chinese composition ends without changes in IE11

[robbertbrak]

To reproduce:

• Use the latest version of Draft (i.e., one that includes 634bd29)
• In IE11, open the rich text example
• Switch to Chinese (Simplified, PRC), and use the IME "Microsoft Pinyin New Experience Input Style". This one comes standard with Windows 7.
• Type ni and then press backspace twice.
• Type ni again.

Result: the cursor stays on the first (blank) line, whereas the letters ni and the Chinese completions appear on the next line. This is incorrect: there shouldn't be a blank line

• Type 1 and press enter.

Result: the editor now contains a blank line (with the cursor), followed by a line with the character 你, followed by a line with the character n. This is incorrect: the editor should only contain 你 and nothing else.

• Type wo1 and press enter.

Result: the editor now contains a line with n, followed by a line with the character 我. This is incorrect: the character 你 has somehow disappeared and the n suddenly moved to the top of the editor.

The screencast below shows more clearly what happens:

I believe that the editorstate breaks immediately after the step "Type ni and then press backspace twice", which is the first time a composition is resolved.

This might be related to #2080, but it's not the same. The fix that I proposed for that issue does not solve this one.

[robbertbrak]

When I change acceptSelection on line https://github.com/facebook/draft-js/blob/943f6dce5188724a11bb392645f5873fe5dcf1a6/src/component/handlers/composition/DraftEditorCompositionHandler.js#L228 to forceSelection, the issue goes away.

@fabiomcosta: Again, I'd be interested to hear what your thoughts are. Is there any particular reason why you would not want to force the selection after resolving a composition?

[fabiomcosta]

Hi Robbert, TBH I wasn’t sure about what to do for this specific part of the code, and I couldn’t see any issues with the current implementation. Thank you for finding all this! Feel free to send PRs to fix those, or I’ll try to do that when I find some time this week.

On Tue, May 28, 2019 at 5:21 AM Robbert Brak ***@***.***> wrote: When I change acceptSelection on line https://github.com/facebook/draft-js/blob/943f6dce5188724a11bb392645f5873fe5dcf1a6/src/component/handlers/composition/DraftEditorCompositionHandler.js#L228 to forceSelection, the issue goes away. @fabiomcosta <https://github.com/fabiomcosta>: Again, I'd be interested to hear what your thoughts are. Is there any particular reason why you would *not* want to force the selection after resolving a composition? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2093>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAG64VGGQ4P5H3A6Z4R4FDPXUPVLANCNFSM4HQCYTIQ> .

-- -- Fabio Miranda Costa *twitter:* @fabioMiranda *github:* fabiomcosta