Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Update link to Immutable Map in docs #2530

Closed

Conversation

agarwalrounak
Copy link
Contributor

Summary
Map in docs, wherever mentioned, links to http://facebook.github.io/immutable-js/docs/#/Map and also in some cases to http://facebook.github.io/immutable-js/docs/#/Record/Record which then redirect to https://immutable-js.github.io/immutable-js/

However, the correct link for Map is https://immutable-js.github.io/immutable-js/docs/#/Map

Draft.js uses immutable 3.7.4 which released on 18 Jun 2015 according to this commit immutable-js/immutable-js@09f04e9
I have linked Map to the docs for that version(captured on 23 Jun 2015) through the Internet Archive.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mrkev
Copy link
Contributor

mrkev commented Jul 28, 2020

This is awesome, thanks @agarwalrounak!

@facebook-github-bot
Copy link

@mrkev merged this pull request in 31dde91.

alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary:
**Summary**
Map in docs, wherever mentioned, links to http://facebook.github.io/immutable-js/docs/#/Map and also in some cases to http://facebook.github.io/immutable-js/docs/#/Record/Record which then redirect to https://immutable-js.github.io/immutable-js/

However, the correct link for Map is https://immutable-js.github.io/immutable-js/docs/#/Map

Draft.js uses immutable 3.7.4 which released on 18 Jun 2015 according to this commit immutable-js/immutable-js@09f04e9
I have linked `Map` to the docs for that version(captured on 23 Jun 2015) through the Internet Archive.

Pull Request resolved: facebookarchive/draft-js#2530

Reviewed By: creedarky

Differential Revision: D22784847

Pulled By: mrkev

fbshipit-source-id: e91c92d2d26b09266bc6e53bb5e0eed0646ec60a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants