This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Save model chat rating in output file #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Currently, the model chat crowdsourcing task does not save the final rating to the summary output file (which typically has a name like
"20210119_161519_102_sandbox.json"). This PR remedies that, and then modifies the analysis script to work with the slightly changed way in which the final rating is now saved. The logic for adding the final set of turn annotations has also been cleaned up.Testing steps
Crowdsourcing CI checks for model chat: regular model chat, model image chat, and model chat analysis. Also ran sandbox HIT and confirmed that the rating is now saved in the output file