This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Modernize natural_questions with add_cmdline_args; add flag for context #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to get rid of the context and figured I should add a new cmdline arg. Natural questions doesn't currently use cmdline arguments, so update it so that it does. Keep the old versions around for backward compatability purposes. Test Plan: Variations of the flag with ``` parlai display_data -t natural_questions -dt valid:stream ``` ensuring that the output is reasonable.
| @@ -277,5 +305,5 @@ def __init__(self, opt, shared=None): | |||
| super().__init__(opt, shared) | |||
|
|
|||
|
|
|||
| class DefaultTeacher(NaturalQuestionsTeacherShortAnswer): | |||
There was a problem hiding this comment.
I am not using this old version. And I not sure if anyone else does. I guess it should be OK to remove, or add a warning for deprecation in like 2 month if someone imports it.
mojtaba-komeili
approved these changes
Feb 9, 2021
Didn't want to remove them outright in case someone was using them, but search suggests they're not. (Which is consistent with @mojtaba-komeili's comment prior)
stephenroller
pushed a commit
that referenced
this pull request
Feb 11, 2021
…xt (#3440) * Modernize natural_questions with add_cmdline_args; add flag for context I want to get rid of the context and figured I should add a new cmdline arg. Natural questions doesn't currently use cmdline arguments, so update it so that it does. Keep the old versions around for backward compatability purposes. Test Plan: Variations of the flag with ``` parlai display_data -t natural_questions -dt valid:stream ``` ensuring that the output is reasonable. * Remove unused teachers Didn't want to remove them outright in case someone was using them, but search suggests they're not. (Which is consistent with @mojtaba-komeili's comment prior)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to get rid of the context and figured I should add a new cmdline arg. Natural questions doesn't currently use cmdline arguments, so update it so that it does.
Keep the old versions around for backward compatability purposes.
Test Plan:
Variations of the flag with
ensuring that the output is reasonable.