Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Speed up conversation openers for self chat. #3461

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Speed up conversation openers for self chat. #3461

merged 1 commit into from
Feb 22, 2021

Conversation

stephenroller
Copy link
Contributor

Patch description
Speed up tests/test_self_chat.py from ~30s to ~1.5s

Methods:

  • Avoid using a real model in the test, which is unnecessarily slow on CPU for unit tests
  • Avoid using repeat_label when loading conversation openers, which causes metrics to be computed, slowing down things significantly.

Testing steps
CI

spencerp
spencerp approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@spencerp spencerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for doing this!

@stephenroller stephenroller merged commit 7815c73 into master Feb 22, 2021
@stephenroller stephenroller deleted the fastselfchat branch February 22, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spencerp spencerp spencerp approved these changes

@mojtaba-komeili mojtaba-komeili mojtaba-komeili approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenroller @spencerp @mojtaba-komeili @facebook-github-bot