[BE] - Deprecate colab #1742
Merged
[BE] - Deprecate colab #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jimmytyyang
approved these changes
Jan 9, 2024
|
|
||
| HTML( | ||
| '<iframe src="https://drive.google.com/file/d/1ltrse38i8pnJPGAXlThylcdy8PMjUMKh/preview" width="640" height="480" allow="autoplay"></iframe>' | ||
| # NOTE: this file is unreachable |
There was a problem hiding this comment.
Hi Alex, thank you for this PR!
Do we want to remove this given that we cannot reach this file?
There was a problem hiding this comment.
@ASzot I think you set this up originally. Is this file somewhere? Is it important?
There was a problem hiding this comment.
I'll merge the current changes and we can remove or re-link the video later.
Yes, I have been running them locally to test the changes. I didn't write the tutorials, so there may be some content decay, but the cells all run and produce output with no show-stopping runtime errors. |
jimmytyyang
pushed a commit
that referenced
this pull request
Jan 14, 2024
* rename 'colabs/' to 'notebooks/' and refactor links * refactor colabs to running Jupyter notebooks
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* rename 'colabs/' to 'notebooks/' and refactor links * refactor colabs to running Jupyter notebooks
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* rename 'colabs/' to 'notebooks/' and refactor links * refactor colabs to running Jupyter notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Colab is a shifting foundtation for hosting tutorials. Back-end changes require updates to installers and scripts resulting in tutorial downtime and extra developer bandwidth load. Instead, we opt to deprecate Colab support and convert existing tutorials to locally-executable Jupyter notebooks.
examples/tutorials/colabs/ directory renamed to examples/tutorials/notebooks/
NOTE: partner habitat-sim PR: facebookresearch/habitat-sim#2298
How Has This Been Tested
Locally ran the Jupyter notebooks
Types of changes
Checklist