HITL - Fix debug viewport size calculation. #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
0mdc
changed the title
henrysamer
approved these changes
Jan 30, 2024
0mdc
changed the title
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Use floating point division instead of integer division to resolve viewport multiplier. Fractional DPI (<1.0) would result in a 0 viewport multiplier when rounding down after division.
This fixes the following error when creating a debug view in the HITL tool:
assert viewport_multiplier[0] > 0 and viewport_multiplier[1] > 0(hitl_main.py)How Has This Been Tested
Tested locally on: Fedora + KDE + RPM Fusion NVIDIA drivers
Types of changes
Checklist