Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - Check remote client input. #1788

Merged
merged 1 commit into from
Feb 5, 2024
Merged

HITL - Check remote client input. #1788

merged 1 commit into from
Feb 5, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Feb 5, 2024

Motivation and Context

This checks for null client inputs. This can now happen with the mouse/keyboard clients as XR pose structs are never created.

Required for: eundersander/siro_hitl_unity_client#24

How Has This Been Tested

Tested locally with the mouse/keyboard remote app.

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 5, 2024
Copy link
Contributor

@henrysamer henrysamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good!

Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0mdc 0mdc merged commit 067202b into main Feb 5, 2024
4 checks passed
@0mdc 0mdc deleted the hitl-check-client-input branch February 5, 2024 19:06
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants