Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL: Add networking config. #1792

Merged
merged 2 commits into from
Feb 5, 2024
Merged

HITL: Add networking config. #1792

merged 2 commits into from
Feb 5, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Feb 5, 2024 •
edited
Loading

Motivation and Context

This small refactor adds a networking config, which is intended to contain the parameters that will control networking properties and remote features.

remote_gui_mode has been moved into this config as networking.enabled.

How Has This Been Tested

Tested locally.

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 5, 2024
eundersander
eundersander approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a naming change but otherwise LGTM!

examples/hitl/pick_throw_vr/config/experiment/headless_server.yaml Outdated Show resolved Hide resolved
@0mdc 0mdc merged commit 000df80 into main Feb 5, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the hitl-remote-gui-config-refactor branch February 5, 2024 23:03
@0mdc 0mdc changed the title Add remote_gui config. HITL: Add networking config. Feb 5, 2024
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
Add remote_gui config. (facebookresearch#1792)
87e8b06 
* Add remote_gui config.

* Rename 'remote_gui' to 'networking'
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@0mdc
Add remote_gui config. (facebookresearch#1792)
97e8b31 
* Add remote_gui config.

* Rename 'remote_gui' to 'networking'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eundersander eundersander eundersander approved these changes

@henrysamer henrysamer Awaiting requested review from henrysamer

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @eundersander @facebook-github-bot