HITL: Add HTTP availability server #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
eundersander
commented
Feb 6, 2024
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| habitat_hitl: | |||
| window: ~ | |||
| networking: | |||
There was a problem hiding this comment.
See comments in hitl_defaults.yaml.
| threading.Event() if multiprocessing_config.use_dummy else None | ||
| ) | ||
| # we don't support dummy multiprocessing at this time | ||
| assert not multiprocessing_config.use_dummy |
There was a problem hiding this comment.
It's not worth the complexity of maintaining the dummy-multiprocessing version of all this.
There was a problem hiding this comment.
Should we just remove it, and introduce it again if we need it?
| start_server = websockets.serve( | ||
| network_mgr_lambda, "0.0.0.0", 8888, ssl=ssl_context | ||
|
|
||
| async def networking_main_async(interprocess_record): |
There was a problem hiding this comment.
The big refactor here is that all our networking logic is now implemented with async/await. Reviewers should take some time to make sure they understand how networking_main_async and networking_main work.
0mdc
approved these changes
Feb 7, 2024
| threading.Event() if multiprocessing_config.use_dummy else None | ||
| ) | ||
| # we don't support dummy multiprocessing at this time | ||
| assert not multiprocessing_config.use_dummy |
There was a problem hiding this comment.
Should we just remove it, and introduce it again if we need it?
| # Handle SIGTERM. We should get this signal when we do networking_process.terminate(). See terminate_networking_process. | ||
| stop: asyncio.Future = asyncio.Future() | ||
| loop = asyncio.get_event_loop() | ||
| loop.add_signal_handler(signal.SIGTERM, stop.set_result, None) |
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* add http availability server; refactor of networking process main loop * add HTML stub client * fixups after rebasing * documentation polish
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* add http availability server; refactor of networking process main loop * add HTML stub client * fixups after rebasing * documentation polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested
Local testing and AWS testing with HTML stub client.
Types of changes
Checklist