--Test fixes to support semantic sensor updates #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
11 tasks
jturner65
force-pushed
the
SemanticSensorUpdates
branch
from
297586e
to
f36616d
Compare
Hardcoded values referring to the stage needed to be changed.
jturner65
force-pushed
the
SemanticSensorUpdates
branch
from
f36616d
to
5a9f1c7
Compare
aclegg3
approved these changes
Feb 26, 2024
0mdc
approved these changes
Feb 26, 2024
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* --fix test_sim_utils Hardcoded values referring to the stage needed to be changed. * --remove magic numbers for test_robot_wrapper ids * --modify reference to stage ID from magic number to habitat_sim.stage_id constant. * --further references
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* --fix test_sim_utils Hardcoded values referring to the stage needed to be changed. * --remove magic numbers for test_robot_wrapper ids * --modify reference to stage ID from magic number to habitat_sim.stage_id constant. * --further references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes tests that reference the hardcoded stage ID in habitat-sim.
This value has changed from -1 to 0, to facilitate the object id/panoptic sensor capabilities being introduced in this PRUntil the above referenced Sim PR is merged, however, this PR will fail on test_sim_utils.py
The stage ID value is now backed by a constant
habitat_sim.stage_id.This PR aims to replace all of the hard-coded numeric references to the stage with this constant.How Has This Been Tested
Locally with above-referenced Habitat-Sim PR.
Types of changes
Checklist