Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL: Add camera sync support. #1811

Merged
merged 2 commits into from
Feb 21, 2024
Merged

HITL: Add camera sync support. #1811

merged 2 commits into from
Feb 21, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Feb 17, 2024

Motivation and Context

This adds camera synchronization to the HITL tool.
When habitat_hitl.networking.active_features.camera_sync is active, the server sends its camera transform to the client.

Unity client PR: 0mdc/siro_hitl_unity_client#2.

How Has This Been Tested

Tested locally in Unity.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 17, 2024
@0mdc 0mdc mentioned this pull request Feb 17, 2024
Merged
eundersander
eundersander approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, otherwise LGTM

habitat-hitl/habitat_hitl/config/hitl_defaults.yaml Outdated Show resolved Hide resolved
habitat-hitl/habitat_hitl/_internal/hitl_driver.py Outdated Show resolved Hide resolved
habitat-hitl/habitat_hitl/core/client_message_manager.py Outdated Show resolved Hide resolved
@0mdc 0mdc merged commit 7855ca4 into main Feb 21, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the hitl-camera-sync branch February 21, 2024 19:01
henrysamer pushed a commit that referenced this pull request Feb 21, 2024
@0mdc @henrysamer
HITL: Add camera sync support. (#1811)
8562e63 
* Add camera sync support to HITL.

* Renaming and refactoring.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
HITL: Add camera sync support. (facebookresearch#1811)
b4cbdf1 
* Add camera sync support to HITL.

* Renaming and refactoring.
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@0mdc
HITL: Add camera sync support. (facebookresearch#1811)
37bc2f4 
* Add camera sync support to HITL.

* Renaming and refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eundersander eundersander eundersander approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@henrysamer henrysamer Awaiting requested review from henrysamer

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @eundersander @facebook-github-bot