[bugfix] - minor generator fixes #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
xavierpuigf
approved these changes
Feb 23, 2024
0mdc
approved these changes
Feb 23, 2024
| "position": [0.0, 0.0, 0.0], | ||
| "orientation": [0.0, 0.0, 0.0], | ||
| "position": [0, 0, 0], | ||
| "orientation": [0, 0, 0.0], |
There was a problem hiding this comment.
Nit: The Z component is still a float.
There was a problem hiding this comment.
These values were set to floats specifically by this pr
5 tasks
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* a collection of minor, indipendent fixes centered on the generator
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* a collection of minor, indipendent fixes centered on the generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR contains three minor, independent fixes from #1770:
DebugVisualizer.peek_scenenow defaults to a topdown viewObjectSampler.sample_placementnow correctly uses the global "up" vector of the receptacle for initial snap_down position.settle_simallowing objects added to a "None" receptacle object for "floor" placements.How Has This Been Tested
in other branch logic from habitat-llm and #1770
Types of changes
Checklist