HITL - Add GUI rendering wrapper. #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Looks good.
I was thinking about ways to reduce the API forwarding/mirroring.
Talking to @0mdc we concluded that this intermediate class will have expanded function variable set and a branched implementation for client-side interface, so this mirror is a lesser of two evils for now.
…awer. Add accessor for internal line renderer. Remove networking placeholder. Fix typing.
0mdc
force-pushed
the
0mdc/hitl-gui-drawer
branch
from
e5ef51e
to
af89e28
Compare
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Add GuiDrawer class. * Change gui_drawer creation flow. Change line renderer calls to gui_drawer. Add accessor for internal line renderer. Remove networking placeholder. Fix typing. * Minor fixed. * Adapt remaining code to use gui_drawer. * Add comments. * Fix typing and typos.
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* Add GuiDrawer class. * Change gui_drawer creation flow. Change line renderer calls to gui_drawer. Add accessor for internal line renderer. Remove networking placeholder. Fix typing. * Minor fixed. * Adapt remaining code to use gui_drawer. * Add comments. * Fix typing and typos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds a wrapper for
DebugLineRender, which also supports networking viaClientMessageManager.DebugLineRenderisNone(headless mode), server rendering is skipped.ClientMessageManagerisNone(local mode), remote rendering is skipped.Rendering for multiple clients would be supported by either adding a "destination" parameter to
GuiDrawerfunctions (relayed toClientMessageManager), or carrying an array ofGuiDrawersandClientMessageManagers. I think that the former would be simpler in the long run.How Has This Been Tested
Tested in all apps along with the Unity mouse/keyboard client.
Types of changes
Checklist