HITL - Remote keyboard input redirection. #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
0mdc
commented
Mar 11, 2024
|
|
||
| # Stub version of Application.MouseEvent.Button | ||
| class StubMouseNS(metaclass=StubNSMeta): | ||
| pass |
There was a problem hiding this comment.
These class will go away in a later pass.
| KeyNS = Application.KeyEvent.Key | ||
| MouseNS = Application.MouseEvent.Button | ||
| KeyNS = KeyCode | ||
| MouseNS = StubMouseNS |
There was a problem hiding this comment.
These won't be needed anymore. They will be removed in a later pass.
| assert isinstance(mouse_button, Application.MouseEvent.Button) | ||
| # if not do_agnostic_gui_input: | ||
| # assert isinstance(mouse_button, Application.MouseEvent.Button) | ||
| pass |
There was a problem hiding this comment.
Mouse tracking will be added in a following PR.
| interprocess_record: InterprocessRecord, | ||
| debug_line_render, | ||
| gui_input: GuiInput, | ||
| ): |
There was a problem hiding this comment.
This is where the redirection happens. RemoteGuiInput used to create its own internal GuiInput - now it's passed as a dependency.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Move key mapping to its own file. Simplify key handling. * Pass GuiInput to RemoteGuiInput to enable remote control. * Activate keyboard redirection. Add 'in' override to KeyCode. * Add missing typing annotation.
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* Move key mapping to its own file. Simplify key handling. * Pass GuiInput to RemoteGuiInput to enable remote control. * Activate keyboard redirection. Add 'in' override to KeyCode. * Add missing typing annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This changeset enables remote keyboard input redirection.
It works by assigning
RemoteGuiInput's internalGuiInputto the applicationGuiInput. Therefore, any key received from a client will update the state as if they were local.Beware that
RemoteGuiInputwill be renamed toRemoteClientState: #1852The following changes are applied:
AbstractKeyNS- only maintain a single keymap for local or remote (KeyCodeenum).KeyCode.How Has This Been Tested
Tested locally with a Unity client.
Types of changes
Checklist